Messages in this thread Patch in this message | | | From | Wen Yang <> | Subject | [PATCH] Fix invalid use of sizeof in stm32_sai_add_mclk_provider() | Date | Tue, 27 Nov 2018 20:35:20 +0800 |
| |
sizeof(mclk) is 4 or 8 as it is the size of a pointer, but we want to reserve space for the pointed data. This issue was detected by using the Coccinelle software.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> CC: Olivier Moysan <olivier.moysan@st.com> CC: Arnaud Pouliquen <arnaud.pouliquen@st.com> CC: Liam Girdwood <lgirdwood@gmail.com> CC: Jaroslav Kysela <perex@perex.cz> CC: Takashi Iwai <tiwai@suse.com> CC: Maxime Coquelin <mcoquelin.stm32@gmail.com> CC: Alexandre Torgue <alexandre.torgue@st.com> CC: Julia Lawall <julia.lawall@lip6.fr> CC: Wen Yang <yellowriver2010@hotmail.com> CC: linux-stm32@st-md-mailman.stormreply.com CC: linux-kernel@vger.kernel.org --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index ea05cc91aa05..211589b0b2ef 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -390,7 +390,7 @@ static int stm32_sai_add_mclk_provider(struct stm32_sai_sub_data *sai) char *mclk_name, *p, *s = (char *)pname; int ret, i = 0; - mclk = devm_kzalloc(dev, sizeof(mclk), GFP_KERNEL); + mclk = devm_kzalloc(dev, sizeof(*mclk), GFP_KERNEL); if (!mclk) return -ENOMEM; -- 2.19.1
| |