lkml.org 
[lkml]   [2018]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V12 05/20] block: remove bvec_iter_rewind()
On Mon, Nov 26, 2018 at 10:17:05AM +0800, Ming Lei wrote:
> Commit 7759eb23fd980 ("block: remove bio_rewind_iter()") removes
> bio_rewind_iter(), then no one uses bvec_iter_rewind() any more,
> so remove it.

Reviewed-by: Omar Sandoval <osandov@fb.com>

> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> include/linux/bvec.h | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
> diff --git a/include/linux/bvec.h b/include/linux/bvec.h
> index 02c73c6aa805..ba0ae40e77c9 100644
> --- a/include/linux/bvec.h
> +++ b/include/linux/bvec.h
> @@ -92,30 +92,6 @@ static inline bool bvec_iter_advance(const struct bio_vec *bv,
> return true;
> }
>
> -static inline bool bvec_iter_rewind(const struct bio_vec *bv,
> - struct bvec_iter *iter,
> - unsigned int bytes)
> -{
> - while (bytes) {
> - unsigned len = min(bytes, iter->bi_bvec_done);
> -
> - if (iter->bi_bvec_done == 0) {
> - if (WARN_ONCE(iter->bi_idx == 0,
> - "Attempted to rewind iter beyond "
> - "bvec's boundaries\n")) {
> - return false;
> - }
> - iter->bi_idx--;
> - iter->bi_bvec_done = __bvec_iter_bvec(bv, *iter)->bv_len;
> - continue;
> - }
> - bytes -= len;
> - iter->bi_size += len;
> - iter->bi_bvec_done -= len;
> - }
> - return true;
> -}
> -
> #define for_each_bvec(bvl, bio_vec, iter, start) \
> for (iter = (start); \
> (iter).bi_size && \
> --
> 2.9.5
>

\
 
 \ /
  Last update: 2018-11-26 23:17    [W:0.180 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site