lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V12 09/20] block: use bio_for_each_bvec() to compute multi-page bvec count
Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Nitpick below:

> +{
> + unsigned len = bv->bv_len;
> + unsigned total_len = 0;
> + unsigned new_nsegs = 0, seg_size = 0;
> +
> + /*
> + * Multipage bvec may be too big to hold in one segment,
> + * so the current bvec has to be splitted as multiple
> + * segments.
> + */

Please use up all 80 chars in a line.

\
 
 \ /
  Last update: 2018-11-26 14:12    [W:0.158 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site