| Date | Tue, 9 Oct 2018 02:50:48 +0200 | From | Andrew Lunn <> | Subject | Re: [RFC PATCH 05/11] net: ethernet: ti: cpsw: add support for port interface mode selection phy |
| |
> /* Configure GMII_SEL register */ > - cpsw_phy_sel(cpsw->dev, slave->phy->interface, slave->slave_num); > + if (!IS_ERR(slave->data->ifphy)) > + phy_set_netif_mode(slave->data->ifphy, slave->data->phy_if);
Is slave->data->phy_if also passed to phy_connect()? So you are going to end up with both the MAC and the PHY inserting RGMII delays, and it not working.
You need to somehow decide if the MAC is going to do the delay, or the PHY. But not both.
Andrew
|