Messages in this thread | | | Date | Tue, 9 Oct 2018 13:30:17 -0700 | From | Tony Lindgren <> | Subject | Re: [RFC PATCH 02/11] dt-bindings: phy: add cpsw port interface mode selection phy bindings |
| |
* Grygorii Strashko <grygorii.strashko@ti.com> [181009 20:10]: > > > On 10/09/2018 09:40 AM, Tony Lindgren wrote: > > * Grygorii Strashko <grygorii.strashko@ti.com> [181008 23:54]: > >> +Examples: > >> + phy_gmii_sel: phy-gmii-sel { > >> + compatible = "ti,am3352-phy-gmii-sel"; > >> + syscon-scm = <&scm_conf>; > >> + #phy-cells = <2>; > >> + }; > > > > Now that this driver can live in it's proper place in the > > right > > > dts, you may want to consider just using standard reg > > property for it instead of the syscon-scm. And also get > > rid of the syscon reads and writes. > > Could you help clarify how to get syscon in this case? > syscon_node_to_regmap(dev->parent->of_node)?
Hmm I don't think you need syscon at all now. You can just ioremap the register(s) and use readl/writel and that's it. Or use regmap without syscon if you prefer that.
The ioremap in this case should be hitting cached ranges anyways, so no extra overhead there.
> Also, there are could be more then one gmii_sel registers in SCM in the future, > so I hidden offsets in of_match data. > As result, "reg" not needed at all now.
But then you have to patch driver for various SoCs instead of just configuring the standard reg property in the dts file :)
Regards,
Tony
| |