Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] staging: bcm2835-camera: remove extraneous setting of dev->colourfx.enable | Date | Mon, 8 Oct 2018 15:50:12 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
Currently dev->colourfx.enable is being set twice, hence the first occurrance is redundant and can be removed, so remove it. This minor issue was introduced by commit 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.").
Detected by CoverityScan CID#1419711 ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index a2c55cb2192a..99831dd4365d 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -588,7 +588,6 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev, control = &dev->component[MMAL_COMPONENT_CAMERA]->control; - dev->colourfx.enable = (ctrl->val & 0xff00) >> 8; dev->colourfx.enable = ctrl->val & 0xff; ret = vchiq_mmal_port_parameter_set(dev->instance, control, -- 2.17.1
| |