Messages in this thread | | | Subject | Re: [PATCH] KVM: X86: Add missing KVM_AMD dependency | From | Paolo Bonzini <> | Date | Mon, 8 Oct 2018 13:27:35 +0200 |
| |
On 06/10/2018 22:43, Guenter Roeck wrote: >> >>>> Maybe this works as well? I haven't tested it yet: >>>> >>> I am sure there are many possible solutions. I would personally >>> prefer one >>> that enforces KVM_AMD=m with CRYPTO_DEV_CCP_DD=m, but that is just me. >> >> Well, KVM_AMD=y is a relatively unusual choice to begin with. The > > It is common enough that we are not the only ones affected. Also, even a > "relatively unusual choice" should, in my opinion, not result in a build > error.
Of course not! The question is whether to solve it by disabling KVM_AMD_SEV (which is what the current code attempts to do, and my patch should fix that) or KVM_AMD (your patch).
Paolo
> Never mind, I'll just apply the suggested workaround and configure > CRYPTO_DEV_CCP_DD=y. I need to do that anyway, after all, if I want to keep > KVM_AMD=y.
| |