Messages in this thread | | | From | Rob Herring <> | Date | Fri, 5 Oct 2018 09:53:08 -0500 | Subject | Re: [PATCH 15/16] of: unittest: initialize args before calling of_irq_parse_one() |
| |
On Thu, Oct 4, 2018 at 11:14 PM <frowand.list@gmail.com> wrote: > > From: Frank Rowand <frank.rowand@sony.com> > > Callers of of_irq_parse_one() blindly use the pointer args.np > without checking whether of_irq_parse_one() had an error and > thus did not set the value of args.np. Initialize args to > zero so that using the format "%pOF" to show the value of > args.np will show "(null)" when of_irq_parse_one() has an > error and does not set args.np instead of trying to > dereference a random value. > > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > --- > drivers/of/unittest.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Does this need to be part of this series?
Rob
| |