lkml.org 
[lkml]   [2018]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/16] of: overlay: make all pr_debug() and pr_err() messages unique
    Date
    From: Frank Rowand <frank.rowand@sony.com>

    Make overlay.c debug and error messages unique so that they can be
    unambiguously found by grep.

    Signed-off-by: Frank Rowand <frank.rowand@sony.com>
    ---
    drivers/of/overlay.c | 12 +++++++-----
    1 file changed, 7 insertions(+), 5 deletions(-)

    diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
    index e6fb3ffe9d93..f89383331b88 100644
    --- a/drivers/of/overlay.c
    +++ b/drivers/of/overlay.c
    @@ -513,7 +513,7 @@ static int build_changeset_symbols_node(struct overlay_changeset *ovcs,
    for_each_property_of_node(overlay_symbols_node, prop) {
    ret = add_changeset_property(ovcs, target, prop, 1);
    if (ret) {
    - pr_debug("Failed to apply prop @%pOF/%s, err=%d\n",
    + pr_debug("Failed to apply symbols prop @%pOF/%s, err=%d\n",
    target->np, prop->name, ret);
    return ret;
    }
    @@ -557,7 +557,8 @@ static int build_changeset(struct overlay_changeset *ovcs)
    ret = build_changeset_next_level(ovcs, &target,
    fragment->overlay);
    if (ret) {
    - pr_debug("apply failed '%pOF'\n", fragment->target);
    + pr_debug("fragment apply failed '%pOF'\n",
    + fragment->target);
    return ret;
    }
    }
    @@ -570,7 +571,8 @@ static int build_changeset(struct overlay_changeset *ovcs)
    ret = build_changeset_symbols_node(ovcs, &target,
    fragment->overlay);
    if (ret) {
    - pr_debug("apply failed '%pOF'\n", fragment->target);
    + pr_debug("symbols fragment apply failed '%pOF'\n",
    + fragment->target);
    return ret;
    }
    }
    @@ -879,7 +881,7 @@ static int of_overlay_apply(const void *fdt, struct device_node *tree,

    ret = __of_changeset_apply_notify(&ovcs->cset);
    if (ret)
    - pr_err("overlay changeset entry notify error %d\n", ret);
    + pr_err("overlay apply changeset entry notify error %d\n", ret);
    /* notify failure is not fatal, continue */

    list_add_tail(&ovcs->ovcs_list, &ovcs_list);
    @@ -1138,7 +1140,7 @@ int of_overlay_remove(int *ovcs_id)

    ret = __of_changeset_revert_notify(&ovcs->cset);
    if (ret)
    - pr_err("overlay changeset entry notify error %d\n", ret);
    + pr_err("overlay remove changeset entry notify error %d\n", ret);
    /* notify failure is not fatal, continue */

    *ovcs_id = 0;
    --
    Frank Rowand <frank.rowand@sony.com>
    \
     
     \ /
      Last update: 2018-10-05 06:15    [W:2.937 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site