Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 4 Oct 2018 11:02:10 +0200 | Subject | Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator |
| |
On Wed, Oct 3, 2018 at 1:49 PM Leonard Crestez <leonard.crestez@nxp.com> wrote: > On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote:
> > I guess I could hack to make "gpios" be ignored by the > > regulator GPIO quirks in gpiolib, but I take it you probably > > prefer to fix up the real issue like this. > > Maybe you could document in fixed-regulator bindings that it now > supports the standard "gpios" property as well? There still seems to be > a restriction that the list must contain a single element.
OK you're right, fixing the docs to be more standards compliant is indeed better.
> Anyway, what my patch fixes is a board-specific issue which exists even > outside your patch: the enet phy regulator never worked as expected.
Indeed.
Yours, Linus Walleij
| |