Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 2 Oct 2018 21:56:39 +0200 | Subject | Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator |
| |
On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: > Convert to use GPIO descriptor only") which causes the "gpios" property > to also be parsed. Before that commit the "gpios" property had no > effect and PHY reset was only handled in the bootloader.
Wow that was a very interesting one. Turning over these stones sometimes expose the weirdest things.
This is one of the reasons why we need formal validation of DTS files: things look OK to the human eye and get merged but they are just syntactically wrong.
I guess I could hack to make "gpios" be ignored by the regulator GPIO quirks in gpiolib, but I take it you probably prefer to fix up the real issue like this.
Anyways, good job! Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |