Messages in this thread Patch in this message | | | Subject | [PATCH] block: fix comments about choosing request list | From | Konstantin Khlebnikov <> | Date | Tue, 16 Oct 2018 11:53:41 +0300 |
| |
Request list is determined by blk_get_rl() and without queue_lock.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> --- include/linux/blk-cgroup.h | 8 ++++---- include/linux/blkdev.h | 9 +++++---- 2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 6d766a19f2bb..dbff5a25f810 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -520,10 +520,10 @@ static inline void blkg_put(struct blkcg_gq *blkg) * @q: request_queue of interest * @bio: bio which will be attached to the allocated request (may be %NULL) * - * The caller wants to allocate a request from @q to use for @bio. Find - * the request_list to use and obtain a reference on it. Should be called - * under queue_lock. This function is guaranteed to return non-%NULL - * request_list. + * The caller wants to allocate a request from @q to use for @bio. + * Find the request_list to use and obtain a reference on it. + * + * This function is guaranteed to return non-%NULL request_list. */ static inline struct request_list *blk_get_rl(struct request_queue *q, struct bio *bio) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 6980014357d4..b5fec0bc72f2 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -444,10 +444,11 @@ struct request_queue { struct rq_qos *rq_qos; /* - * If blkcg is not used, @q->root_rl serves all requests. If blkcg - * is used, root blkg allocates from @q->root_rl and all other - * blkgs from their own blkg->rl. Which one to use should be - * determined using bio_request_list(). + * If blkcg is not used, @q->root_rl serves all requests. + * If blkcg is used, root blkg allocates from @q->root_rl and + * all other blkgs from their own blkg->rl. + * + * Which one to use should be determined using blk_get_rl(). */ struct request_list root_rl;
| |