Messages in this thread | | | Date | Mon, 15 Oct 2018 20:38:07 +0200 | From | Greg KH <> | Subject | Re: [PATCH v3 09/15] platform: goldfish: pipe: Move goldfish_pipe to goldfish_pipe_v2 |
| |
On Wed, Oct 03, 2018 at 10:17:14AM -0700, rkir@google.com wrote: > From: Roman Kiryanov <rkir@google.com> > > This is the v2 driver. v1 will be added later.
This does not make any sense. Why are you renaming a driver that has been in the tree already? It's not "v2", it is what we have today.
If you want to add a new driver later, great, but don't change the name of an existing driver for no good reason. Userspace has a tendancy to break when that happens.
thanks,
greg k-h
| |