Messages in this thread | | | From | Roman Kiryanov <> | Date | Mon, 15 Oct 2018 11:48:28 -0700 | Subject | Re: [PATCH v3 06/15] platform: goldfish: pipe: Move memory allocation from probe to init |
| |
> You should only allocate memory at probe time
probe does not know what memory to allocate. We have several versions of the driver (with different init) and different versions allocate different state.
>, not init time as what > happens if the hardware is not present yet your driver is loaded?
init will have to rollback what it allocated.
| |