Messages in this thread | | | Date | Thu, 11 Oct 2018 23:11:21 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions |
| |
On Mon, Sep 24, 2018 at 04:52:34PM -0700, Stephen Boyd wrote: > We never really look at the 'ret' local variable in these functions, so > let's remove it to make way for shorter and simpler code. Furthermore, > we can shorten some lines by adding two local variables for the SE and > the message length so that everything fits in 80 columns and testing the > 'dma_buf' local variable in lieu of the 'mode' local variable. And > kernel style is to leave the return statement by itself, detached from > the rest of the function. > > Cc: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> > Cc: Sagar Dharia <sdharia@codeaurora.org> > Cc: Girish Mahadevan <girishm@codeaurora.org> > Cc: Doug Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Applied to for-next, thanks!
[unhandled content-type:application/pgp-signature] | |