Messages in this thread | | | Date | Thu, 04 Oct 2018 13:16:26 +0530 | From | alokc@codeauro ... | Subject | Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler |
| |
On 2018-09-26 03:19, Doug Anderson wrote: > Hi, > > On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd <swboyd@chromium.org> > wrote: >> >> We don't need to use goto here, we can just collapse the if statement >> and goto chain into multiple branches and then combine some duplicate >> completion calls into one big if statement. Let's do it to clean up >> code >> some more. >> >> Cc: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> >> Cc: Sagar Dharia <sdharia@codeaurora.org> >> Cc: Girish Mahadevan <girishm@codeaurora.org> >> Cc: Doug Anderson <dianders@chromium.org> >> Signed-off-by: Stephen Boyd <swboyd@chromium.org> >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 70 >> +++++++++++++----------------- >> 1 file changed, 29 insertions(+), 41 deletions(-) > > It doesn't gleam as powerfully the cleanups in patch 2/3 but this does > have a few nice readability improvements. > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
agree.
Reviewed-by: Alok Chauhan <alokc@codeaurora.org>
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,a Linux Foundation Collaborative Project
| |