Messages in this thread | | | Subject | Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof | From | "Andrew F. Davis" <> | Date | Mon, 8 Jan 2018 10:25:57 -0600 |
| |
On 01/08/2018 05:59 AM, Mark Brown wrote: > On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote: >> A single cache element may not always be unsigned int, use a >> cache element in sizeof over hard-coding its type. > > A cache element is *always* unsigned int. What you mean to say here is > that this helps if in future someone changes the code to use a different > type, it's not fixing a memory corruption problem that exists now which > is what your commit message suggests. >
Right, will re-word.
| |