Messages in this thread | | | Date | Mon, 8 Jan 2018 11:59:14 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof |
| |
On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote: > A single cache element may not always be unsigned int, use a > cache element in sizeof over hard-coding its type.
A cache element is *always* unsigned int. What you mean to say here is that this helps if in future someone changes the code to use a different type, it's not fixing a memory corruption problem that exists now which is what your commit message suggests. [unhandled content-type:application/pgp-signature] | |