Messages in this thread | | | Date | Wed, 24 Jan 2018 08:12:48 -0500 | From | Steven Rostedt <> | Subject | [PATCH 0/3] [GIT PULL] ftrace,orc,x86: Handle ftrace dynamically allocated trampolines |
| |
Linus,
With the new ORC unwinder, ftrace stack tracing became disfunctional.
One was that ORC didn't know how to handle the ftrace callbacks in general (which Josh fixed). The other was that ORC would just bail if it hit a dynamically allocated trampoline. Which means all ftrace stack tracing that happens from the function tracer would produce no results (that includes killing the max stack size tracer). I added a check to the ORC unwinder to see if the trampoline belonged to ftrace, and if it did, use the orc entry of the static trampoline that was used to create the dynamic one (it would be identical).
Finally, I noticed that the skip values of the stack tracing were out of whack. I went through and fixed them up.
Please pull the latest trace-v4.15-rc9 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git trace-v4.15-rc9
Tag SHA1: b3e8c85438a8abb5a41864103a52c48787e610ce Head SHA1: 2ee5b92a2598d9e403337185fdf88f661dee8616
Josh Poimboeuf (1): x86/ftrace: Fix ORC unwinding from ftrace handlers
Steven Rostedt (VMware) (2): ftrace, orc, x86: Handle ftrace dynamically allocated trampolines tracing: Update stack trace skipping for ORC unwinder
---- arch/x86/kernel/Makefile | 5 +++- arch/x86/kernel/ftrace_64.S | 24 +++++++++++------- arch/x86/kernel/unwind_orc.c | 48 +++++++++++++++++++++++++++++++++++- include/linux/ftrace.h | 2 ++ kernel/trace/ftrace.c | 29 +++++++++++++--------- kernel/trace/trace.c | 34 ++++++++++++++----------- kernel/trace/trace_events_trigger.c | 13 ++++++++-- kernel/trace/trace_functions.c | 49 +++++++++++++++++++++++++++---------- 8 files changed, 152 insertions(+), 52 deletions(-)
| |