Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT | Date | Sun, 14 Jan 2018 21:11:18 -0800 |
| |
From: Randy Dunlap <rdunlap@infradead.org>
Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that.
This also makes all platform/x86/ drivers consistent w.r.t depending on INPUT instead of selecting it.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Darren Hart <dvhart@infradead.org> Cc: Andy Shevchenko <andy@infradead.org> Cc: platform-driver-x86@vger.kernel.org --- drivers/platform/x86/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
--- lnx-415-rc8.orig/drivers/platform/x86/Kconfig +++ lnx-415-rc8/drivers/platform/x86/Kconfig @@ -812,9 +812,8 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" - depends on ACPI + depends on ACPI && INPUT depends on RFKILL || RFKILL=n - select INPUT select BACKLIGHT_CLASS_DEVICE help Support for Intel Classmate PC ACPI devices, including some
| |