Messages in this thread Patch in this message | | | From | Eric Auger <> | Subject | [PATCH] vfio: fix noiommu vfio_iommu_group_get reference count | Date | Tue, 8 Aug 2017 22:44:28 +0200 |
| |
In vfio_iommu_group_get() we want to increase the reference count of the iommu group.
In noiommu case, the group does not exist and is allocated. iommu_group_add_device() increases the group ref count. However we then call iommu_group_put() which decrements it.
This leads to a "refcount_t: underflow WARN_ON".
Signed-off-by: Eric Auger <eric.auger@redhat.com> --- drivers/vfio/vfio.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 330d505..fd8d691 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -138,7 +138,6 @@ struct iommu_group *vfio_iommu_group_get(struct device *dev) iommu_group_set_name(group, "vfio-noiommu"); iommu_group_set_iommudata(group, &noiommu, NULL); ret = iommu_group_add_device(group, dev); - iommu_group_put(group); if (ret) return NULL; -- 2.5.5
| |