lkml.org 
[lkml]   [2017]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: isofs: One check less in isofs_read_inode() after error detection
From
Date
> I agree that
>
> fail:
> goto out;
>
> in the original code is awkward and we can get rid of it.

How would you like to change this place instead?


> However renaming labels is IMO pointless and
>
>> if (bh)
>> +release_bh:
>> brelse(bh);
>> return ret;
>
> is just disgusting.

I know that it can be occasionally harder to achieve the desired consensus.

Regards,
Markus

\
 
 \ /
  Last update: 2017-08-21 16:19    [W:0.041 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site