lkml.org 
[lkml]   [2017]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection
On Sat 19-08-17 09:18:42, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 19 Aug 2017 08:10:40 +0200
>
> * Adjust jump targets.
>
> * Avoid a repeated check for the local variable "bh" after
> a memory allocation failure in this function.
>
> * Delete an initialisation for the local variable "ret"
> which became unnecessary with this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

I agree that

fail:
goto out;

in the original code is awkward and we can get rid of it. However renaming
labels is IMO pointless and

> if (bh)
> +release_bh:
> brelse(bh);
> return ret;

is just disgusting.

Honza

--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2017-08-21 16:11    [W:0.087 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site