lkml.org 
[lkml]   [2017]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 3/5] reset: stm32: use the reset-simple driver
Date
Hi Philipp,

On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote:
> The reset-simple driver can be used without changes.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> [snip]
>
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata
> reset_simple_active_low = {
>  
>  static const struct of_device_id reset_simple_dt_ids[] = {
>   { .compatible = "altr,rst-mgr", .data =
> &reset_simple_socfpga },
> + { .compatible = "st,stm32-rcc", },
>   { .compatible = "allwinner,sun6i-a31-clock-reset",
>   .data = &reset_simple_active_low },
>   { /* sentinel */ },

What about adding generic compatible strings for future use?
I mean next:

--------------------->8---------------------

static const struct of_device_id reset_simple_dt_ids[] = {
{ .compatible = "reset-simple-active-low",
.data = &reset_simple_active_low },
{ .compatible = "reset-simple-active-high",
.data = &reset_simple_active_high },
/* ... */
{ /* sentinel */ },
};

static const struct reset_simple_devdata reset_simple_active_high = {
.active_low = false,
};

static const struct reset_simple_devdata reset_simple_active_low = {
.active_low = true,
};

--------------------->8---------------------

--
 Eugeniy Paltsev
\
 
 \ /
  Last update: 2017-08-16 14:53    [W:0.095 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site