Messages in this thread | | | Date | Wed, 2 Aug 2017 01:22:17 +0200 | From | "Luis R. Rodriguez" <> | Subject | Re: lib/test_kmod.c:750: possible garbled statement order ? |
| |
On Mon, Jul 17, 2017 at 07:38:40AM +0000, David Binderman wrote: > Hello there, > > > lib/test_kmod.c:750]: (style) Statements following return, break, continue, goto or throw will never be executed. > > case TEST_KMOD_FS_TYPE: > break; > kfree_const(config->test_fs); > config->test_driver = NULL; > copied = config_copy_test_fs(config, test_str, > strlen(test_str)); > default: > > Suggest move the break to just before the default label. > > Regards
Thanks David, Dan Carpenter sent a fix for this [0] and I've queued the patch in.
[0] https://lkml.kernel.org/r/20170707084117.jbi3g364jz75liay@mwanda
Luis
| |