Messages in this thread Patch in this message | | | From | sathyanarayanan.kuppuswamy@linux ... | Subject | [PATCH v1 1/1] mux: mux-core: Add NULL check for dev->of_node | Date | Fri, 7 Jul 2017 14:42:30 -0700 |
| |
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
If dev->of_node is NULL, then calling mux_control_get() function can lead to NULL pointer exception. So adding a NULL check for dev->of_node.
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> --- drivers/mux/mux-core.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c index 90b8995..f226662 100644 --- a/drivers/mux/mux-core.c +++ b/drivers/mux/mux-core.c @@ -438,6 +438,9 @@ struct mux_control *mux_control_get(struct device *dev, const char *mux_name) int index = 0; int ret; + if (!np) + return ERR_PTR(-ENODEV); + if (mux_name) { index = of_property_match_string(np, "mux-control-names", mux_name); @@ -448,6 +451,7 @@ struct mux_control *mux_control_get(struct device *dev, const char *mux_name) } } + ret = of_parse_phandle_with_args(np, "mux-controls", "#mux-control-cells", index, &args); -- 2.7.4
| |