Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Arvind Yadav <> | Subject | [PATCH 5/5] mm: hugetlb: constify attribute_group structures. | Date | Thu, 27 Jul 2017 17:37:40 +0530 |
| |
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- mm/hugetlb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bc48ee7..2ecd09d 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2569,13 +2569,13 @@ static ssize_t surplus_hugepages_show(struct kobject *kobj, NULL, }; -static struct attribute_group hstate_attr_group = { +static const struct attribute_group hstate_attr_group = { .attrs = hstate_attrs, }; static int hugetlb_sysfs_add_hstate(struct hstate *h, struct kobject *parent, struct kobject **hstate_kobjs, - struct attribute_group *hstate_attr_group) + const struct attribute_group *hstate_attr_group) { int retval; int hi = hstate_index(h); @@ -2633,7 +2633,7 @@ struct node_hstate { NULL, }; -static struct attribute_group per_node_hstate_attr_group = { +static const struct attribute_group per_node_hstate_attr_group = { .attrs = per_node_hstate_attrs, }; -- 1.9.1
| ![\](/images/icornerr.gif) |