Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH] ocfs2: constify attribute_group structures. | Date | Fri, 30 Jun 2017 13:23:09 +0530 |
| |
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 4402 1088 38 5528 1598 fs/ocfs2/stackglue.o
File size After adding 'const': text data bss dec hex filename 4442 1024 38 5504 1580 fs/ocfs2/stackglue.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- fs/ocfs2/stackglue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index 8203590..d6c350b 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c @@ -631,7 +631,7 @@ static ssize_t ocfs2_dlm_recover_show(struct kobject *kobj, NULL, }; -static struct attribute_group ocfs2_attr_group = { +static const struct attribute_group ocfs2_attr_group = { .attrs = ocfs2_attrs, }; -- 1.9.1
| |