lkml.org 
[lkml]   [2017]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2
From
Date
On 04/04/2017 08:56 PM, Dmitry Monakhov wrote:
> bio_integrity_trim inherent it's interface from bio_trim and accept
> offset and size, but this API is error prone because data offset
> must always be insync with bio's data offset. That is why we have
> integrity update hook in bio_advance()
>
> So only meaningful values are: offset == 0, sectors == bio_sectors(bio)
> Let's just remove them completely.
>
> changes from v1:
> - remove 'sectors' arguments
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> block/bio-integrity.c | 11 ++---------
> block/bio.c | 4 ++--
> drivers/md/dm.c | 2 +-
> include/linux/bio.h | 5 ++---
> 4 files changed, 7 insertions(+), 15 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

\
 
 \ /
  Last update: 2017-04-05 08:37    [W:0.275 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site