| Subject | Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2 | From | "Martin K. Petersen" <> | Date | Wed, 19 Apr 2017 22:38:52 -0400 |
| |
Dmitry Monakhov <dmonakhov@openvz.org> writes:
> bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset must > always be insync with bio's data offset. That is why we have integrity > update hook in bio_advance() > > So only meaningful values are: offset == 0, sectors == > bio_sectors(bio) Let's just remove them completely.
This interface predates the iter/immutable stuff. It should be fine to remove the call arguments now.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
-- Martin K. Petersen Oracle Linux Engineering
|