Messages in this thread | | | From | Andrey Smirnov <> | Date | Wed, 19 Apr 2017 09:04:52 -0700 | Subject | Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts |
| |
[ +cc: Marek, since I accidentally dropped him off CC list ]
On Wed, Apr 19, 2017 at 8:35 AM, David Woodhouse <dwmw2@infradead.org> wrote: > On Wed, 2017-04-19 at 08:23 -0700, Andrey Smirnov wrote: >> No functional change intended. > > FWIW I *deliberately* used the proper C datatypes throughout all of the > MTD code instead of the silly kernel-speshul datatypes. To the extent > of *fixing* submissions to be written in C when they were using the > silly kernel types instead. > > There is a reason for the __u32 type in userspace APIs. There is > basically no reason for 'u32' et al, just to save a trivial few > characters in the type name. We might as well be using the proper > language types. > > I appreciate that not everyone agrees with that, but at least it used > to be consistent throughout the code I was maintaining. I'll defer to > the currently active maintainers though...
This conversion was an explicit request from Marek, see https://marc.info/?l=linux-kernel&m=149192751625941
Thanks, Andrey Smirnov
| |