Messages in this thread | | | Subject | Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts | From | David Woodhouse <> | Date | Wed, 19 Apr 2017 16:35:12 +0100 |
| |
On Wed, 2017-04-19 at 08:23 -0700, Andrey Smirnov wrote: > No functional change intended.
FWIW I *deliberately* used the proper C datatypes throughout all of the MTD code instead of the silly kernel-speshul datatypes. To the extent of *fixing* submissions to be written in C when they were using the silly kernel types instead.
There is a reason for the __u32 type in userspace APIs. There is basically no reason for 'u32' et al, just to save a trivial few characters in the type name. We might as well be using the proper language types.
I appreciate that not everyone agrees with that, but at least it used to be consistent throughout the code I was maintaining. I'll defer to the currently active maintainers though...[unhandled content-type:application/x-pkcs7-signature] | |