lkml.org 
[lkml]   [2017]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[RFC PATCH] apic: drop useless apic_read
Date
APIC ESR register reading doesn't clear its content.

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
It is also a question represented by a patch: Intel developer manual
doesn't say reading will clear it content, so why read it here?

arch/x86/kernel/apic/apic.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 8ccb7ef..1742324 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1065,7 +1065,6 @@ void clear_local_APIC(void)
if (maxlvt > 3)
/* Clear ESR due to Pentium errata 3AP and 11AP */
apic_write(APIC_ESR, 0);
- apic_read(APIC_ESR);
}
}

--
2.1.0


\
 
 \ /
  Last update: 2017-04-19 11:29    [W:0.023 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site