Messages in this thread Patch in this message | | | From | Myungho Jung <> | Subject | [PATCH] timer: fix timer_migration to accept only 0 and 1 | Date | Wed, 19 Apr 2017 15:24:50 -0700 |
| |
Error is not shown by setting invalid value to timer_migration. Valid values for timer_migration should be restricted to 0 and 1. Testcase for this bug is ltp/runpwtests06.
Signed-off-by: Myungho Jung <mhjungk@gmail.com> --- kernel/sysctl.c | 2 ++ kernel/time/timer.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 8c8714f..21343d1 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1176,6 +1176,8 @@ static struct ctl_table kern_table[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = timer_migration_handler, + .extra1 = &zero, + .extra2 = &one, }, #endif #ifdef CONFIG_BPF_SYSCALL diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 1dc0256..cc6b6bd 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -241,7 +241,7 @@ int timer_migration_handler(struct ctl_table *table, int write, int ret; mutex_lock(&mutex); - ret = proc_dointvec(table, write, buffer, lenp, ppos); + ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); if (!ret && write) timers_update_migration(false); mutex_unlock(&mutex); -- 2.7.4
| |