Messages in this thread Patch in this message | | | Date | Wed, 15 Mar 2017 14:55:06 +0900 | From | Daeseok Youn <> | Subject | [PATCH 1/4] staging: atomisp: fix unsigned int comparison with less than zero |
| |
Fix warnings from the smatch tool
atomisp_cmd.c:2649 atomisp_set_array_res() warn: unsigned 'config->width' is never less than zero.
atomisp_cmd.c:2650 atomisp_set_array_res() warn: unsigned 'config->height' is never less than zero.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c index 1ee99d0..9c3ba11 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c @@ -2646,8 +2646,7 @@ int atomisp_set_array_res(struct atomisp_sub_device *asd, struct atomisp_resolution *config) { dev_dbg(asd->isp->dev, ">%s start\n", __func__); - if (config == NULL || config->width < 0 - || config->height < 0) { + if (!config) { dev_err(asd->isp->dev, "Set sensor array size is not valid\n"); return -EINVAL; } -- 1.9.1
| |