Messages in this thread Patch in this message | | | From | Nikolay Borisov <> | Subject | [PATCH] lockdep: Teach lockdep about memalloc_noio_save | Date | Wed, 1 Mar 2017 09:48:26 +0200 |
| |
Commit 21caf2fc1931 ("mm: teach mm by current context info to not do I/O during memory allocation") added the memalloc_noio_(save|restore) functions to enable people to modify the MM behavior by disbaling I/O during memory allocation. This prevents allocation paths recursing back into the filesystem without explicitly changing the flags for every allocation site. Yet, lockdep not being aware of that is prone to showing false positives. Fix this by teaching it that the presence of PF_MEMALLOC_NOIO flag mean we are not going to issue any I/O
Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- kernel/locking/lockdep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 9812e5dd409e..5715fdcede28 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -2866,7 +2866,8 @@ static void __lockdep_trace_alloc(gfp_t gfp_mask, unsigned long flags) return; /* this guy won't enter reclaim */ - if ((curr->flags & PF_MEMALLOC) && !(gfp_mask & __GFP_NOMEMALLOC)) + if (((curr->flags & PF_MEMALLOC) && !(gfp_mask & __GFP_NOMEMALLOC)) || + curr->flags & PF_MEMALLOC_NOIO) return; /* We're only interested __GFP_FS allocations for now */ -- 2.7.4
| |