Messages in this thread | | | From | Namhyung Kim <> | Date | Wed, 22 Feb 2017 20:22:57 +0900 | Subject | Re: [PATCH 2/4] perf annotate: Align filename:linenr and more correct summary |
| |
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.taeung@gmail.com> wrote: > In the stdio interface, currently 'filename:linenr' infos > are confusedly printed in the intervals of assembly code. > So fix it. > > The cause was a 0.5% filter of if statement. After fixed, > additionally summary of overhead per srcline is more correct. > > Before: > > # perf annotate --stdio -l > > Sorted summary for file /home/taeung/workspace/perf-test/test > ---------------------------------------------- > > 36.57 test.c:38 > 28.72 test.c:37 > > ... > > Percent | Source code & Disassembly of test ... > > ... > > 0.21 : 400816: push %rbp > test.c:26 1.86 : 400817: mov %rsp,%rbp > 0.21 : 40081a: mov %edi,-0x24(%rbp) > 0.21 : 40081d: mov %rsi,-0x30(%rbp) > > After: > > # perf annotate --stdio -l > > Sorted summary for file /home/taeung/workspace/perf-test/test > ---------------------------------------------- > > 37.40 test.c:38 > 29.34 test.c:37 > > ... > > Percent | Source code & Disassembly of test ... > > ... > > test.c:26 > 0.21 : 400816: push %rbp > 1.86 : 400817: mov %rsp,%rbp > 0.21 : 40081a: mov %edi,-0x24(%rbp) > 0.21 : 40081d: mov %rsi,-0x30(%rbp)
I guess it's just a problem of a missing newline..
Thanks, Namhyung
| |