Messages in this thread | | | Subject | Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code | From | Taeung Song <> | Date | Thu, 23 Feb 2017 01:41:03 +0900 |
| |
On 02/22/2017 08:27 PM, Namhyung Kim wrote: > On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.taeung@gmail.com> wrote: >> The output of perf-annotate has a problem. >> It is so confusing that the output is mixed with >> both source code and assembly code. >> IMHO, we need readable annotate view based on source code, >> not mixed view. (not depending on 'objdump -S') >> >> And to do that, we can collect actual source code per function(sym) >> using addr2line() and we can handle 'struct source_code' >> that contains each line of code. >> >> In near future, it would be used for new annotate view based on >> actual source code per function(sym). > > I think this is just a preparation so you'd be better sending it with > your new annotate view patchset later. > > Thanks, > Namhyung
I got it! I thought it is needed to separate a big commit into several commits so I sent this patch before including new annotate view.
But as you said, it seems like just a preparation without important point(new view). So I'll send v2 with new annotate view !
Thanks, Taeung
| |