Messages in this thread | | | Date | Fri, 10 Feb 2017 07:22:29 -0600 | From | Bin Liu <> | Subject | Re: [PATCH] drivers: usb: musb: add code comment for clarification |
| |
On Thu, Feb 09, 2017 at 09:56:54PM -0600, Gustavo A. R. Silva wrote: > Add code comment to make it clear that the fall-through is intentional. > Read the link for more details: https://lkml.org/lkml/2017/2/9/292 >
Don't need 'drivers:' in the subject.
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/usb/musb/musb_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 892088f..1aec986 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb *musb) > > return; > } > + /* FALLTHROUGH */
/* fall through */ as in CodingStyle.
> case MUSB_QUIRK_A_DISCONNECT_19: > if (musb->quirk_retries--) { > musb_dbg(musb, > --
Regards, -Bin.
| |