Messages in this thread | | | From | Ben Whitten <> | Subject | [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger | Date | Tue, 5 Dec 2017 11:19:10 +0000 |
| |
From: Ben Whitten <ben.whitten@gmail.com>
The patch was converted to led_blink_oneshot, in doing so we find that the behaviour has changed. As I dont want to break 'userspace' led behaviour this patch shouldn't be merged as is. Open to suggestions.
Given an interval of 50ms and heavy throughput, the previous implementation produced a blink with 100ms period and 50% dutycycle. The led_blink_oneshot version produces a blink with 140ms period and 57% dutycycle. I assume a fudge factor on the oneshot delay to bring the period back to 100ms would be device specific so not suitable.
Kind regards, Ben Whitten (1): leds: trigger: Introduce a NETDEV trigger
.../ABI/testing/sysfs-class-led-trigger-netdev | 45 ++ drivers/leds/trigger/Kconfig | 7 + drivers/leds/trigger/Makefile | 1 + drivers/leds/trigger/ledtrig-netdev.c | 507 +++++++++++++++++++++ 4 files changed, 560 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-netdev create mode 100644 drivers/leds/trigger/ledtrig-netdev.c
-- 2.7.4
| |