Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH v2 1/5] x86/stacktrace: do now unwind after user regs | Date | Tue, 5 Dec 2017 09:55:34 +0100 |
| |
Josh pointed out, that there is no way a frame can be after user regs. So remove the last unwind and the check.
Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Cc: Josh Poimboeuf <jpoimboe@redhat.com> --- arch/x86/kernel/stacktrace.c | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c index 77835bc021c7..b088d4f9e43e 100644 --- a/arch/x86/kernel/stacktrace.c +++ b/arch/x86/kernel/stacktrace.c @@ -113,15 +113,6 @@ __save_stack_trace_reliable(struct stack_trace *trace, if (!user_mode(regs)) return -EINVAL; - /* - * The last frame contains the user mode syscall - * pt_regs. Skip it and finish the unwind. - */ - unwind_next_frame(&state); - if (!unwind_done(&state)) { - STACKTRACE_DUMP_ONCE(task); - return -EINVAL; - } break; } -- 2.15.1
| |