Messages in this thread | | | Date | Mon, 4 Dec 2017 13:24:19 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h |
| |
On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote: > Renames enum dataMode and its values packet, continuous, continuousNoSync > to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes > checkpatch.pl warnings: "Avoid CamelCase: <dataMode>, <continuousNoSync>".
These names are too generic. Delete them. Use DATAMODUL_MODE_PACKET and friends directly.
int rf69_set_data_mode(struct spi_device *spi, u8 val) { return WRITE_REG(REG_DATAMODUL, (READ_REG(REG_DATAMODUL) & ~MASK_DATAMODUL_MODE) | val); }
Only DATAMODUL_MODE_PACKET is ever used. There is no need to validate the parameters.
regards, dan carpenter
| |