Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 4 Dec 2017 13:37:19 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h |
| |
On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: > Perhaps choose different function names if you want? You could do it > as several patches: > > patch 1: change types to bool > patch 2: sed -e '/ == optionOn//' > patch 3: split the functions into two functions > patch 4: delete optionOnOff enum > > patches 1 and 2 could be merged together (your choice). >
Markus says that optionOn is used by user space so my you won't be able to remove these entirely. But as much as possible we should internally.
regards, dan carpenter
| ![\](/images/icornerr.gif) |