Messages in this thread | | | Subject | Re: [PATCH 11/13] cxl: Remove support for "Processing accelerators" class | From | Andrew Donnellan <> | Date | Tue, 19 Dec 2017 10:47:04 +1100 |
| |
On 19/12/17 02:21, Frederic Barrat wrote: > The cxl driver currently declares in its table of supported PCI > devices the class "Processing accelerators". Therefore it may be > called to probe for opencapi devices, which generates errors, as the > config space of a cxl device is not compatible with opencapi. > > So remove support for the generic class, as we now have (at least) two > drivers for devices of the same class. Most cxl devices are FPGAs with > a PSL which will show a known device ID of 0x477. Other devices are > really supported by the cxlflash driver and are already listed in the > table. So removing the class is expected to go unnoticed. > > Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> --- > drivers/misc/cxl/pci.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index 19969ee86d6f..758842f65a1b 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -125,8 +125,6 @@ static const struct pci_device_id cxl_pci_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0601), }, > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0623), }, > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0628), }, > - { PCI_DEVICE_CLASS(0x120000, ~0), }, > - > { } > }; > MODULE_DEVICE_TABLE(pci, cxl_pci_tbl); >
-- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited
| |