Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled | Date | Mon, 13 Nov 2017 16:18:01 -0800 |
| |
Stefan Schake <stschake@gmail.com> writes:
> The overflow mem work callback vc4_overflow_mem_work reenables its > associated interrupt upon completion. To ensure all interrupts are disabled > when we return from vc4_irq_uninstall, we need to disable it again if > cancel_work_sync indicated pending work.
Is there a reason we need the interrupts disabled at the V3D level while we have the IRQ disabled at the irqchip level? Once we re-enable at the irqchip, we immediately V3D_WRITE(V3D_INTENA, V3D_DRIVER_IRQS) anyway. [unhandled content-type:application/pgp-signature] | |