Messages in this thread | | | Date | Fri, 6 Oct 2017 10:14:08 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails |
| |
On Mon, Oct 02, 2017 at 11:56:48AM -0400, Joe Lawrence wrote: > When an incoming module is considered for livepatching by > klp_module_coming(), it iterates over multiple patches and multiple > kernel objects in this order: > > list_for_each_entry(patch, &klp_patches, list) { > klp_for_each_object(patch, obj) { > > which means that if one of the kernel objects fails to patch, > klp_module_coming()'s error path needs to unpatch and cleanup any kernel > objects that were already patched by a previous patch. > > Reported-by: Miroslav Benes <mbenes@suse.cz> > Suggested-by: Petr Mladek <pmladek@suse.com> > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> > --- > v2: > > - cleanup comment describing the new function > - s/klp_cleanup_module_objects_limited/klp_cleanup_module_patches_limited > - added a suggested-by tag for Petr since he suggested both code and > commentary :)
Any more comments on this patch? This is holding up the callbacks patch so it would be great if we could get this merged soon.
-- Josh
| |