Messages in this thread | | | Date | Tue, 10 Oct 2017 14:31:45 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails |
| |
On Mon 2017-10-02 11:56:48, Joe Lawrence wrote: > When an incoming module is considered for livepatching by > klp_module_coming(), it iterates over multiple patches and multiple > kernel objects in this order: > > list_for_each_entry(patch, &klp_patches, list) { > klp_for_each_object(patch, obj) { > > which means that if one of the kernel objects fails to patch, > klp_module_coming()'s error path needs to unpatch and cleanup any kernel > objects that were already patched by a previous patch. > > Reported-by: Miroslav Benes <mbenes@suse.cz> > Suggested-by: Petr Mladek <pmladek@suse.com> > Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
Looks good to me.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |