Messages in this thread Patch in this message | | | From | SF Markus Elfring <> | Subject | [PATCH] Input-mpr121: Use common error handling code in mpr_touchkey_interrupt() | Date | Thu, 26 Oct 2017 21:23:56 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 26 Oct 2017 21:16:53 +0200
Add a jump target so that an error message can be better reused in an if branch of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/input/keyboard/mpr121_touchkey.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/mpr121_touchkey.c b/drivers/input/keyboard/mpr121_touchkey.c index 884a74d8a7ed..af840a842246 100644 --- a/drivers/input/keyboard/mpr121_touchkey.c +++ b/drivers/input/keyboard/mpr121_touchkey.c @@ -129,14 +129,13 @@ static irqreturn_t mpr_touchkey_interrupt(int irq, void *dev_id) int reg; reg = i2c_smbus_read_byte_data(client, ELE_TOUCH_STATUS_1_ADDR); - if (reg < 0) { - dev_err(&client->dev, "i2c read error [%d]\n", reg); - goto out; - } + if (reg < 0) + goto report_read_failure; reg <<= 8; reg |= i2c_smbus_read_byte_data(client, ELE_TOUCH_STATUS_0_ADDR); if (reg < 0) { +report_read_failure: dev_err(&client->dev, "i2c read error [%d]\n", reg); goto out; } -- 2.14.3
| |