Messages in this thread Patch in this message | | | Date | Fri, 20 Oct 2017 22:36:52 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH] net: can: dev: remove unused code in can_restart |
| |
Value assigned to variable err is overwritten at line 562: err = priv->do_set_mode(dev, CAN_MODE_START); before it can be used.
Also, notice that this code has been there since 2014.
Addresses-Coverity-ID: 1227031 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- This code was tested by compilation only.
drivers/net/can/dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 365a8cc..064d0f6 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -543,10 +543,9 @@ static void can_restart(struct net_device *dev) /* send restart message upstream */ skb = alloc_can_err_skb(dev, &cf); - if (skb == NULL) { - err = -ENOMEM; + if (!skb) goto restart; - } + cf->can_id |= CAN_ERR_RESTARTED; netif_rx(skb); -- 2.7.4
| |