Messages in this thread Patch in this message | | | From | Anshuman Khandual <> | Subject | [PATCH] mm/swap: Use page flags to determine LRU list in __activate_page() | Date | Thu, 19 Oct 2017 20:26:57 +0530 |
| |
Its already assumed that the PageActive flag is clear on the input page, hence page_lru(page) will pick the base LRU for the page. In the same way page_lru(page) will pick active base LRU, once the flag PageActive is set on the page. This change of LRU list should happen implicitly through the page flags instead of being hard coded.
Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> --- mm/swap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/swap.c b/mm/swap.c index fcd82bc..494276b 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -275,12 +275,10 @@ static void __activate_page(struct page *page, struct lruvec *lruvec, { if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) { int file = page_is_file_cache(page); - int lru = page_lru_base_type(page); - del_page_from_lru_list(page, lruvec, lru); + del_page_from_lru_list(page, lruvec, page_lru(page)); SetPageActive(page); - lru += LRU_ACTIVE; - add_page_to_lru_list(page, lruvec, lru); + add_page_to_lru_list(page, lruvec, page_lru(page)); trace_mm_lru_activate(page); __count_vm_event(PGACTIVATE); -- 1.8.5.2
| |